Specify target type in create target group #3269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a target group, the default target type is by instance ID, not IP. But we reference IPs in the next step....
Update aws.md
March update
Grammatical fixes
Update what-is-new.md
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.36.0 to 1.36.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.36.0...v1.36.1) Signed-off-by: dependabot[bot] <support@github.com>
…achinery/google.golang.org/grpc-1.36.1 chore: bump google.golang.org/grpc from 1.36.0 to 1.36.1 in /pkg/machinery
smira
reviewed
May 18, 2021
| @@ -215,7 +215,8 @@ aws elbv2 create-target-group \ | |||
| --name talos-aws-tutorial-tg \ | |||
| --protocol TCP \ | |||
| --port 6443 \ | |||
| --vpc-id $VPC | |||
| --vpc-id $VPC \ | |||
| --target-type ip | |||
There was a problem hiding this comment.
this got already fixed in some other PR
smira
added a commit
to smira/talos
that referenced
this pull request
May 18, 2021
From PR siderolabs#3269 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
|
extracted changes to #3637 |
talos-bot
pushed a commit
that referenced
this pull request
May 18, 2021
From PR #3269 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Need to specify the --target-type as IP for the target group. Else it defaults to instance ID.
What? (description)
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)