feat: implement secure boot from disk #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
commented
Jun 14, 2023
| @@ -109,7 +109,7 @@ func NewInstaller(cmdline *procfs.Cmdline, seq runtime.Sequence, opts *Options) | |||
| } | |||
| } | |||
|
|
|||
| i.manifest, err = NewManifest(seq, bootLoaderPresent, i.options) | |||
| i.manifest, err = NewManifest(seq, i.bootloader.UEFIBoot(), bootLoaderPresent, i.options) | |||
There was a problem hiding this comment.
TODO: above, on line 106, needs a way to force a specific bootloader based on Options (flags), so that one could create sd-boot metal image for example
smira
commented
Jun 14, 2023
smira
commented
Jun 14, 2023
| @@ -29,5 +33,10 @@ func PseudoSubMountPoints() (mountpoints *Points, err error) { | |||
| pseudo.Set("hugetlb", NewMountPoint("hugetlbfs", "/dev/hugepages", "hugetlbfs", 0, "")) | |||
| pseudo.Set("securityfs", NewMountPoint("securityfs", "/sys/kernel/security", "securityfs", unix.MS_NOSUID|unix.MS_NOEXEC|unix.MS_NODEV|unix.MS_RELATIME, "")) | |||
|
|
|||
| if _, err := os.Stat(constants.EFIVarsMountPoint); err == nil { | |||
There was a problem hiding this comment.
mount as readonly, remount in the code which writes the vars? better for security
|
/promote integration-trusted-boot |
|
@frezbo please help me to fix this when you're back: |
Seems alpine has a different file: |
Closed
|
/promote integration-trusted-boot |
|
/promote integration-trusted-boot |
|
/promote integration-trusted-boot |
|
/promote integration-trusted-boot |
|
/promote integration-trusted-boot |
|
/promote integration-trusted-boot |
frezbo
force-pushed
the
feat/sd-boot
branch
2 times, most recently
from
7b11f28 to
090631b
Compare
|
/promote integration-trusted-boot |
frezbo
approved these changes
Jun 16, 2023
This includes sd-boot handling, EFI variables, etc. There are some TODOs which need to be addressed to make things smooth. Install to disk, upgrades work. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
|
/m |
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes sd-boot handling, EFI variables, etc.
There are some TODOs which need to be addressed to make things smooth.
Install to disk, upgrades work.