feat: support conditional start of IPv6 dns servers #9596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
ipv6-dns
branch
9 times, most recently
from
5317c7e
to
30292e2
Compare
smira
approved these changes
Oct 30, 2024
DmitriyMV
force-pushed
the
ipv6-dns
branch
3 times, most recently
from
9f20118
to
c21e3b9
Compare
DmitriyMV
force-pushed
the
ipv6-dns
branch
4 times, most recently
from
9f5f13f
to
3bc8aca
Compare
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Nov 8, 2024
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
Merged
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Nov 8, 2024
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Nov 8, 2024
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Nov 8, 2024
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Nov 8, 2024
Split from siderolabs#9596 (without IPv6 stuff). This PR does this things: - Refactored `DNSResolveCacheController`. Most of the logic moved to `dns` package types. Simplify and streamline logic. - Replace most of the goroutine orchestration with suture package. - Support per-item reaction to the dns listeners/servers failing to start. This allows us to ignore IPv6 errors if it's disabled. - Support per-item reaction to the dns listeners/servers failing to stop. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
This PR does those things: - Raise IPv6 listener on link-local address for dns (both TCP and UDP). - Update kubelet's `resolv.conf` IPv4/IPv6 endpoints. Closes siderolabs#9384 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does those things:
resolv.confIPv4/IPv6 endpoints.Closes #9384