chore: add constant for Board Turing RK1 #9869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to add Turing RK1 option in Omni Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
frezbo
reviewed
Dec 3, 2024
| @@ -128,6 +128,9 @@ const ( | |||
| // BoardNanoPiR4S is the name of the Friendlyelec Nano Pi R4S. | |||
| BoardNanoPiR4S = "nanopi_r4s" | |||
|
|
|||
| // BoardTuringRK1 is the name of the Turing RK1 SoM. | |||
There was a problem hiding this comment.
@smira i think we should stop doing this and just hardcode in omni 🤔
There was a problem hiding this comment.
yep, we don't have boards anymore, they are all legacy, and these names don't matter with overlays
nberlee
added a commit
to nberlee/omni
that referenced
this pull request
Dec 3, 2024
This has hardcoded "turingrk1" strings as discussed in siderolabs/talos#9869 Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
Unix4ever
pushed a commit
to nberlee/omni
that referenced
this pull request
Dec 10, 2024
This has hardcoded "turingrk1" strings as discussed in siderolabs/talos#9869 Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
Unix4ever
pushed a commit
to nberlee/omni
that referenced
this pull request
Dec 10, 2024
This has hardcoded "turingrk1" strings as discussed in siderolabs/talos#9869 Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
Unix4ever
pushed a commit
to nberlee/omni
that referenced
this pull request
Dec 10, 2024
This has hardcoded "turingrk1" strings as discussed in siderolabs/talos#9869 Signed-off-by: Nico Berlee <nico.berlee@on2it.net> Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is silly, but the constant is needed for Omni to cleanly add Turing RK1 to:
https://github.com/siderolabs/omni/blob/main/internal/backend/runtime/omni/controllers/omni/installation_media.go#L273
and
https://github.com/siderolabs/omni/blob/main/internal/backend/runtime/omni/controllers/omni/internal/boards/boards.go#L17