fix: generating and serving registries with port #9954
Merged
+174
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
fix/image-cache-registry-with-port
branch
from
e34887f to
979a5ab
Compare
smira
reviewed
Dec 13, 2024
frezbo
force-pushed
the
fix/image-cache-registry-with-port
branch
from
979a5ab to
35c16fd
Compare
frezbo
commented
Dec 13, 2024
internal/app/machined/pkg/system/services/registry/registry_test.go
Outdated
Show resolved
Hide resolved
smira
reviewed
Dec 13, 2024
internal/app/machined/pkg/system/services/registry/registry_test.go
Outdated
Show resolved
Hide resolved
smira
approved these changes
Dec 13, 2024
Fix generating and serving registies having port in them. This is needed to copy and serve imagecache from a vfat filesystem. Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
fix/image-cache-registry-with-port
branch
from
35c16fd to
ab5bb68
Compare
|
now we have good test coverage |
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix generating and serving registies having port in them. This is needed to copy and serve imagecache from a vfat filesystem.