Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Added Privacy Manifest #108

Merged

Conversation

martin-headspace
Copy link
Contributor

@martin-headspace martin-headspace commented Apr 4, 2024

Summary

Added an empty Privacy Manifest to the iOS project in preparation for the May 1st Deadline for 3rd Party SDKs that include native iOS code.

Description

Starting May 1: You’ll need to include approved reasons for the listed APIs used by your app’s code to upload a new or updated app to App Store Connect.
...
Make sure to use a version of the SDK that includes its privacy manifest and note that signatures are also required when the SDK is added as a binary dependency.

Privacy updates for App Store submissions - Latest News - Apple Developer
Upcoming third-party SDK requirements - Support - Apple Developer

Impact and Testing

Developers using an updated version of this library on their iOS projects shouldn't see any issues related to the Privacy Manifest

Contributor Note

Based on the language on Apple's Website, this change seems to be mandatory for all 3rd Party Libraries. The impact of not adding it is unclear to me, but hopefully having it will be better than not.

Added a privacy manifest in prep. for May 1st's deadline for 3rd Party Libraries
@sidlatau
Copy link
Owner

sidlatau commented Apr 5, 2024

Thanks for the PR! But I am not sure if it is needed. Did you get any warnings related to this library when submitting the app?

@martin-headspace
Copy link
Contributor Author

Hey @sidlatau , I haven't received any warnings.

Having said that, I'm following the same philosophy that the flutter team followed on flutter/packages#5846 where it feels like the current list of mandatory plugins was selected arbitrarily, and eventually could grow to use other popular packages (like yours. btw thanks for maintaining it!)

I believe this is specially important given that lacking this manifest may eventually cause problems for updating or releasing new apps to the App Store.

@martin-headspace
Copy link
Contributor Author

You can find other projects that were not listed on the Apple News article but have prepared by adding their Privacy Manifests to their packages:

@sidlatau sidlatau merged commit c561113 into sidlatau:master Apr 5, 2024
@sidlatau
Copy link
Owner

sidlatau commented Apr 5, 2024

Tkanks for the provided details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants