From 86294cf7749185b417b997fb9be8ae9e9fc93d3b Mon Sep 17 00:00:00 2001 From: goncalosard Date: Wed, 5 Jul 2023 12:34:00 +0100 Subject: [PATCH 1/2] fix: deprecate size 32 --- packages/core/component-doc.json | 8 +++++++- packages/core/src/components.d.ts | 2 ++ packages/core/src/components/icon-button/icon-button.tsx | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/core/component-doc.json b/packages/core/component-doc.json index 8b3894bbd64..8f94b588b68 100644 --- a/packages/core/component-doc.json +++ b/packages/core/component-doc.json @@ -5263,8 +5263,14 @@ "attr": "size", "reflectToAttr": false, "docs": "Size of icon in button", - "docsTags": [], + "docsTags": [ + { + "name": "deprecated", + "text": "Size 32 will be removed in 2.0.0" + } + ], "default": "'24'", + "deprecation": "Size 32 will be removed in 2.0.0", "values": [ { "value": "12", diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts index 23196d54a12..310dcfe609c 100644 --- a/packages/core/src/components.d.ts +++ b/packages/core/src/components.d.ts @@ -968,6 +968,7 @@ export namespace Components { "selected": boolean; /** * Size of icon in button + * @deprecated Size 32 will be removed in 2.0.0 */ "size": '32' | '24' | '16' | '12'; /** @@ -3858,6 +3859,7 @@ declare namespace LocalJSX { "selected"?: boolean; /** * Size of icon in button + * @deprecated Size 32 will be removed in 2.0.0 */ "size"?: '32' | '24' | '16' | '12'; /** diff --git a/packages/core/src/components/icon-button/icon-button.tsx b/packages/core/src/components/icon-button/icon-button.tsx index 37e680c618f..817ae68155b 100644 --- a/packages/core/src/components/icon-button/icon-button.tsx +++ b/packages/core/src/components/icon-button/icon-button.tsx @@ -55,6 +55,8 @@ export class IconButton implements Button { /** * Size of icon in button + * + * @deprecated Size 32 will be removed in 2.0.0 */ @Prop() size: '32' | '24' | '16' | '12' = '24'; From db1dbf52a17ad39b0a4b047e4a4fd7ba34fbe6f5 Mon Sep 17 00:00:00 2001 From: goncalosard Date: Thu, 6 Jul 2023 15:00:00 +0100 Subject: [PATCH 2/2] fix: deprecated 3.0.0 --- packages/core/component-doc.json | 4 ++-- packages/core/src/components.d.ts | 4 ++-- packages/core/src/components/icon-button/icon-button.tsx | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/core/component-doc.json b/packages/core/component-doc.json index 8f94b588b68..37482096d24 100644 --- a/packages/core/component-doc.json +++ b/packages/core/component-doc.json @@ -5266,11 +5266,11 @@ "docsTags": [ { "name": "deprecated", - "text": "Size 32 will be removed in 2.0.0" + "text": "Only size 32 will be removed in 3.0.0" } ], "default": "'24'", - "deprecation": "Size 32 will be removed in 2.0.0", + "deprecation": "Only size 32 will be removed in 3.0.0", "values": [ { "value": "12", diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts index 310dcfe609c..6070e8a3a07 100644 --- a/packages/core/src/components.d.ts +++ b/packages/core/src/components.d.ts @@ -968,7 +968,7 @@ export namespace Components { "selected": boolean; /** * Size of icon in button - * @deprecated Size 32 will be removed in 2.0.0 + * @deprecated Only size 32 will be removed in 3.0.0 */ "size": '32' | '24' | '16' | '12'; /** @@ -3859,7 +3859,7 @@ declare namespace LocalJSX { "selected"?: boolean; /** * Size of icon in button - * @deprecated Size 32 will be removed in 2.0.0 + * @deprecated Only size 32 will be removed in 3.0.0 */ "size"?: '32' | '24' | '16' | '12'; /** diff --git a/packages/core/src/components/icon-button/icon-button.tsx b/packages/core/src/components/icon-button/icon-button.tsx index 817ae68155b..ad4777ba5cd 100644 --- a/packages/core/src/components/icon-button/icon-button.tsx +++ b/packages/core/src/components/icon-button/icon-button.tsx @@ -56,7 +56,7 @@ export class IconButton implements Button { /** * Size of icon in button * - * @deprecated Size 32 will be removed in 2.0.0 + * @deprecated Only size 32 will be removed in 3.0.0 */ @Prop() size: '32' | '24' | '16' | '12' = '24';