Picolibc #200
Merged
Picolibc #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
requested review from
bsousi5 and
nategraff-sifive
as code owners
keith-packard
force-pushed
the
picolibc
branch
from
7b811a6 to
ee3dc99
Compare
nategraff-sifive
suggested changes
Oct 31, 2019
|
I'm happy with either version of sbrk, but the ifdef version might be slightly easier to maintain? |
let's use the ifdef one then; we can always switch back :-) |
keith-packard
force-pushed
the
picolibc
branch
from
49953fd to
f86e328
Compare
This provides a definition of size_t Signed-off-by: Keith Packard <keithp@keithp.com>
|
I've rebased and tested this with Nate's updated BSP generation code |
bsousi5
approved these changes
Mar 31, 2020
nategraff-sifive
approved these changes
Mar 31, 2020
This library hooks picolibc to libmetal, offering a small number of APIs. Signed-off-by: Keith Packard <keithp@keithp.com> --- v2: Initialize TLS base register from __tls_base and __tdata_size The RISC-V ABI sets the tp register between tls initialized data and tls uninitialized data areas. The linker sets __tls_base to the start of tls data and __tdata_size to the size of the initialized data area, so the correct tp value is the sum of these two symbols. libriscv__pico__metal.a → libmetal-pico.a Use the name that freedom-e-sdk wants Use gloss/crt0.S and gloss/sys_exit.c for libmetal-pico.a Share source code, especially the startup code, between the two C library users to avoid duplicating work between them. Expose sbrk/brk instead of _sbrk/_brk when compiled against picolibc This changes the names of these two functions when using picolibc instead of newlib. Otherwise, the implementation is the same. Use gloss/sys_sbrk.c with picolibc Instead of a separate copy with minor edits. v3: Use correct TLS initialization value. Risc-V places TP at the base of TLS storage, not between data and BSS values. v4: Fix spelling error in Makefile.am (libmetail-pico → libmetal-pico) Found-by: Nathaniel Graff <nathaniel.graff@sifive.com>
bsousi5
pushed a commit
that referenced
this pull request
Apr 8, 2020
Support Debug/Release build configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'metal-pico' library which contains interfaces for picolibc to sit atop freedom-metal