Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTIF interfaces #57

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Add support for HTIF interfaces #57

merged 4 commits into from
Oct 7, 2019

Conversation

palmer-dabbelt
Copy link
Contributor

This just supports HTIF console (always via the write syscall) and
shutdown (without an exit code). With this I can run code on Spike.

Signed-off-by: Palmer Dabbelt palmer@sifive.com

@bsousi5
Copy link
Collaborator

bsousi5 commented Feb 23, 2019

I only saw fromhost getting initialize to 0, or reset. But what set this value?
Unless it is getting update by Spike given that it is a global variable.

Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@nategraff-sifive nategraff-sifive force-pushed the htif branch 3 times, most recently from 1cbe72b to fc15d7c Compare October 4, 2019 18:04
@nategraff-sifive nategraff-sifive force-pushed the htif branch 2 times, most recently from 79b8fb3 to a2a30a9 Compare October 4, 2019 22:16
palmer-dabbelt and others added 4 commits October 4, 2019 15:56
This just supports HTIF console (always via the write syscall) and
shutdown (without an exit code).  With this I can run code on Spike.

Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
Return the exit code to spike.
- formatting
- require METAL_UCB_HTIF0 to be defined by metal/machine/platform.h
- name the file with an understore instead of a comma
- change getc and putc to accept ints instead of chars

Signed-off-by: Nathaniel Graff <nathaniel.graff@sifive.com>
Signed-off-by: Nathaniel Graff <nathaniel.graff@sifive.com>
Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nategraff-sifive nategraff-sifive merged commit 56bb58e into master Oct 7, 2019
@nategraff-sifive nategraff-sifive deleted the htif branch October 7, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants