Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of pkg_resources with importlib_resources #223

Closed
khmikkelsen opened this issue Aug 22, 2021 · 1 comment
Closed

Replace usage of pkg_resources with importlib_resources #223

khmikkelsen opened this issue Aug 22, 2021 · 1 comment

Comments

@khmikkelsen
Copy link

Replace pkg_resources with importlib_resources as ytmusicapi's usage is limited to the scope of importlib_resources's, and pkg_resources have issues related to python 3.9 with LegacyVersion being deprecated and defaulting to this as mentioned in:

While the issue has been known for a while, fixes are not merged yet.
Motivation for this issue: AppDaemon/appdaemon#1336
@khmikkelsen khmikkelsen mentioned this issue Aug 22, 2021
Closed
@sigma67
Copy link
Owner

sigma67 commented Aug 26, 2021

I like your suggestion to use importlib_resources, but it requires an additional dependency for older Python versions which wasn't needed before. I've chosen to go with an alternate approach that will eliminate the need for pkg_resources.

@sigma67 sigma67 mentioned this issue Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigma67 @khmikkelsen