Remove duplicate assets from SignalShareExtension and consolidate resizable imagesets #6166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izable imagesets - SignalShareExtension was embedding its own copy of Images.xcassets and Symbols.xcassets, duplicating assets already in the main app bundle - Use Bundle.app extension to load images from the containing app instead - Delete *-resizable imagesets (group, person, note, number, invite) which were byte-for-byte identical copies of their base imagesets with the same Contents.json - Update code references to use base imageset names instead of -resizable variants Reduces app bundle size by ~10MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
SignalShareExtension was embedding its own copy of Images.xcassets and Symbols.xcassets, duplicating assets already in the main app bundle. This PR loads images from the containing app instead using the existing
Bundle.appextension.Also removes *-resizable imagesets (group, person, note, number, invite) which were byte-for-byte identical copies of their base imagesets with the same Contents.json.
Changes
Bundle.appextension to load images from the containing appImpact
Reduces app bundle size by ~10MB.