Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Archived Metrics - Routing destination Archived and ExceptionRules #220

Merged
merged 5 commits into from
Aug 10, 2024

Conversation

echoi-splk
Copy link
Collaborator

@echoi-splk echoi-splk commented Aug 1, 2024

Update metricruleset model based on 3.3.0 OpenAPI spec (see https://cd.splunkdev.com/devplat-pr-32/o11y-openapi/-/merge_requests/305)
Add Routing destination "Archived"
Add handling of Metric Ruleset > ExceptionRules

  • Add handling of ExceptionRule > Restoration jobs

Remove metric_ruleset/model_destination.go

  • this file was based on a 2022 early draft of metric rulesets

@echoi-splk echoi-splk requested review from a team as code owners August 1, 2024 12:15
@echoi-splk echoi-splk self-assigned this Aug 1, 2024
@echoi-splk echoi-splk marked this pull request as draft August 1, 2024 12:15
@echoi-splk echoi-splk marked this pull request as ready for review August 8, 2024 00:02
@echoi-splk echoi-splk requested review from atoulme and ndmoeller August 8, 2024 00:03
@atoulme
Copy link
Contributor

atoulme commented Aug 8, 2024

@echoi-splk please do the following:

  • Add yourself to the CODEOWNERS file for all files you should continue to watch and own after this PR
  • Ask a team member to review and approve the changes

@echoi-splk
Copy link
Collaborator Author

@echoi-splk please do the following:

  • Add yourself to the CODEOWNERS file for all files you should continue to watch and own after this PR
  • Ask a team member to review and approve the changes

Done in #221

@echoi-splk echoi-splk closed this Aug 8, 2024
@echoi-splk echoi-splk reopened this Aug 8, 2024
@ndmoeller
Copy link
Collaborator

LGTM

@echoi-splk echoi-splk merged commit 36ea1d8 into master Aug 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants