From 0bab0dbdbe606971c66a88036926bd5404bf7d35 Mon Sep 17 00:00:00 2001
From: dapplion <35266934+dapplion@users.noreply.github.com>
Date: Fri, 26 Apr 2024 13:15:50 +0900
Subject: [PATCH] Deterministic block generation for tests

---
 .../types/src/test_utils/test_random/secret_key.rs    |  2 ++
 .../types/src/test_utils/test_random/signature.rs     | 11 +++++------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/consensus/types/src/test_utils/test_random/secret_key.rs b/consensus/types/src/test_utils/test_random/secret_key.rs
index 3f3f6ed5184..da1614aa24e 100644
--- a/consensus/types/src/test_utils/test_random/secret_key.rs
+++ b/consensus/types/src/test_utils/test_random/secret_key.rs
@@ -2,6 +2,8 @@ use super::*;
 
 impl TestRandom for SecretKey {
     fn random_for_test(_rng: &mut impl RngCore) -> Self {
+        // TODO: Not deterministic generation. Using `SecretKey::deserialize` results in
+        // `BlstError(BLST_BAD_ENCODING)`, need to debug with blst source on what encoding expects.
         SecretKey::random()
     }
 }
diff --git a/consensus/types/src/test_utils/test_random/signature.rs b/consensus/types/src/test_utils/test_random/signature.rs
index 5b952296b61..8bc0d711103 100644
--- a/consensus/types/src/test_utils/test_random/signature.rs
+++ b/consensus/types/src/test_utils/test_random/signature.rs
@@ -1,11 +1,10 @@
 use super::*;
 
 impl TestRandom for Signature {
-    fn random_for_test(rng: &mut impl RngCore) -> Self {
-        let secret_key = SecretKey::random_for_test(rng);
-        let mut message = vec![0; 32];
-        rng.fill_bytes(&mut message);
-
-        secret_key.sign(Hash256::from_slice(&message))
+    fn random_for_test(_rng: &mut impl RngCore) -> Self {
+        // TODO: `SecretKey::random_for_test` does not return a deterministic signature. Since this
+        // signature will not pass verification we could just return the generator point or the
+        // generator point multiplied by a random scalar if we want disctint signatures.
+        Signature::infinity().expect("infinity signature is valid")
     }
 }