Add time metrics to aquire fork-choice lock #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
waiting-on-author
Co-authored-by: Michael Sproul <micsproul@gmail.com>
dapplion
added
ready-for-review
michaelsproul
approved these changes
Aug 19, 2024
michaelsproul
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1f0d129 |
This was referenced Aug 20, 2024
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
* Add time metrics to aquire fork-choice lock * Apply suggestions from code review Co-authored-by: Michael Sproul <micsproul@gmail.com> * Merge remote-tracking branch 'sigp/unstable' into fork-choice-lock-metrics * fix merge issue
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Add time metrics to aquire fork-choice lock * Apply suggestions from code review Co-authored-by: Michael Sproul <micsproul@gmail.com> * Merge remote-tracking branch 'sigp/unstable' into fork-choice-lock-metrics * fix merge issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Better visibility into lock contention issues regarding the fork-choice
Proposed Changes
Add basic time metrics to aquire fork-choice lock, without labels
Possible improvements
fn fork_choice_write_lock(label: &str)so that each caller tags the time measurement by its location.(RwLockWriteGuard<BeaconForkChoice<T>>, HistogramTimer)to always time how long the lock is acquired for. Is there a cleaner way to achieve the same goal generically? Can we mess withRwLockWriteGuard?