Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make portable the default in Lighthouse book and Makefile, update workflows #6247

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Make portable the default in Lighthouse book and Makefile, update workflows #6247

merged 16 commits into from
Aug 19, 2024

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Aug 9, 2024

Since portable is now the default build, this PR:

  • removes some sections in Lighthouse book that are no longer relevant and make portable the default where necessary
  • updates Makefile to use portable as the default build
  • removes the portable tag in release.yml
  • removes the modern tag in docker.yml

@chong-he chong-he added the work-in-progress PR is a work-in-progress label Aug 9, 2024
chong-he
chong-he commented Aug 9, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@chong-he chong-he added ready-for-review The code is ready for review docs Documentation infra-ci and removed work-in-progress PR is a work-in-progress labels Aug 9, 2024
jimmygchen
jimmygchen reviewed Aug 9, 2024
View reviewed changes
book/src/docker.md Outdated Show resolved Hide resolved
jimmygchen
jimmygchen requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just added a small comment.
Be good to get a second review from @michaelsproul or @antondlr .

antondlr
antondlr approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@antondlr antondlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looking good!
now that we're at it I would prefer to remove the -dev tag, too.
no more confusing double tags for any image!

michaelsproul
michaelsproul approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agree we should also get rid of -dev

jimmygchen
jimmygchen approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 19, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Aug 19, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b6d15bc

mergify bot added a commit that referenced this pull request Aug 19, 2024
@mergify
Merge of #6247
a4073ce
This was referenced Aug 19, 2024
Closed
Merged
@michaelsproul michaelsproul added the backwards-incompat Backwards-incompatible API change label Aug 19, 2024
@mergify mergify bot merged commit b6d15bc into sigp:unstable Aug 19, 2024
29 checks passed
@jimmygchen jimmygchen mentioned this pull request Aug 28, 2024
Merged
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
@chong-he @AgeManning
Make portable the default in Lighthouse book and Makefile, update w…
52377e6 
…orkflows (sigp#6247)

* Remove portable in book

* Add back modern in docker.md

* Update Makefile

* Update release.yml

* Update docker.yml

* Update book

* Minor revision

* delete portable tarballs

* delete portable in Make command

* Fix link in book

* mdlint

* Remove modernity in docker

* Merge branch 'unstable' into update-book-portable

* Merge branch 'unstable' into update-book-portable

* Remove `-dev` docker images

* Merge remote-tracking branch 'origin/unstable' into update-book-portable
chong-he added a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@chong-he
Make portable the default in Lighthouse book and Makefile, update w…
d53bdcc 
…orkflows (sigp#6247)

* Remove portable in book

* Add back modern in docker.md

* Update Makefile

* Update release.yml

* Update docker.yml

* Update book

* Minor revision

* delete portable tarballs

* delete portable in Make command

* Fix link in book

* mdlint

* Remove modernity in docker

* Merge branch 'unstable' into update-book-portable

* Merge branch 'unstable' into update-book-portable

* Remove `-dev` docker images

* Merge remote-tracking branch 'origin/unstable' into update-book-portable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antondlr antondlr antondlr approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change docs Documentation infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chong-he @michaelsproul @jimmygchen @antondlr