Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant allocations in blob verification #6282

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Avoid redundant allocations in blob verification #6282

merged 1 commit into from
Aug 20, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Micro-optimisations to allocate 1 vec instead of 2 during KZG blob verification, and removal of an unnecessary clone.

Additional Info

I haven't benchmarked this optimisation but I think it's low-risk and pretty much a no-brainer

@michaelsproul michaelsproul added ready-for-review The code is ready for review optimization Something to make Lighthouse run more efficiently. consensus An issue/PR that touches consensus code, such as state_processing or block verification. labels Aug 20, 2024
@michaelsproul michaelsproul mentioned this pull request Aug 20, 2024
Merged
@realbigsean
Copy link
Member

@mergify queue

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 20, 2024
@mergify Mergify
Copy link

mergify bot commented Aug 20, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify
Merge of #6282
5038486
@mergify mergify bot mentioned this pull request Aug 20, 2024
Closed
5 tasks
@realbigsean
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Aug 20, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Aug 20, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 56d1c8c

mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify
Merge of #6282
c701472
@mergify mergify bot mentioned this pull request Aug 20, 2024
Closed
5 tasks
@mergify mergify bot merged commit 56d1c8c into sigp:unstable Aug 20, 2024
28 checks passed
@michaelsproul michaelsproul deleted the optimise-blob-verification branch August 21, 2024 00:02
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
@michaelsproul @AgeManning
Avoid redundant allocations in blob verification (sigp#6282)
93f8509 
* Avoid redundant allocations in blob verification
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
@michaelsproul @chong-he
Avoid redundant allocations in blob verification (sigp#6282)
8742505 
* Avoid redundant allocations in blob verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. optimization Something to make Lighthouse run more efficiently. ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsproul @realbigsean @kevaundray