Adding info for JS client. #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hayleycd <cook.hayley@gmail.com>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
hayleycd
commented
Nov 3, 2024
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Contributor
Author
|
@bdehamer @haydentherapper suggested that I tag you in for review. I'm happy to make changes. Please let me know what you think. |
bdehamer
reviewed
Nov 5, 2024
bdehamer
left a comment
bdehamer
left a comment
There was a problem hiding this comment.
Some suggestions for the code samples.
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Contributor
Author
|
Thanks for the review @bdehamer. Let me know if you require any more changes! |
haydentherapper
previously approved these changes
Nov 8, 2024
Contributor
|
@hayleycd Can you rebase for the conflict? |
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Contributor
Author
|
@haydentherapper Conflicts have been resolved but the review is now stale. Can you approve again? |
haydentherapper
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #324
Release Note
None