Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigstore, remove deprecated email identity setting #37

Merged
merged 11 commits into from
Nov 28, 2022
Merged

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Nov 24, 2022

WIP. This is probably going to break the CI, since we still do verifications by default but don't always pass in the necessary options.

Removes the verify-oidc-email setting, since it maps to a now-removed sigstore CLI option. This release family of sigstore also makes the various verification options mandatory, so we no longer allow a user to pass verify: true without also passing the specific verification fields they'd like to verify with.

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw self-assigned this Nov 24, 2022
README.md Outdated Show resolved Hide resolved
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

cc @tetsuo-cpp: with these changes, I think we have a couple of options:

  • Disable verification by default: we were doing it primarily as a "smoke test" for the action, but I think the state of our CI both here and on sigstore-python itself now provides sufficient confidence.
  • Keep verification enabled, and infer the correct verification options to pass. When an ambient credential is used this is very easy; when the user passes in their own OIDC identity then we'll also need to enforce that they supply verify-oidc-issuer and verify-cert-identity.

Thoughts?

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

woodruffw commented Nov 28, 2022

I've tweaked the PR to disable verification by default, just to demonstrate what I'm thinking.

Edit: I've also added a matrix of xfail tests, to demonstrate expected failure modes.

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review November 28, 2022 16:47
@woodruffw woodruffw requested a review from di November 28, 2022 16:59
@woodruffw woodruffw merged commit 7a26f57 into main Nov 28, 2022
@woodruffw woodruffw deleted the ww/bump branch November 28, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants