Adding e2e test coverage #1071
Merged
Adding e2e test coverage #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 22, 2022 18:44
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
bobcallaway
reviewed
Sep 22, 2022
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
bobcallaway
previously approved these changes
Sep 23, 2022
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
asraa
previously approved these changes
Sep 23, 2022
Signed-off-by: Ceridwen Driskill <cdriskill@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
===========================================
+ Coverage 41.09% 64.08% +22.98%
===========================================
Files 71 81 +10
Lines 7061 7481 +420
===========================================
+ Hits 2902 4794 +1892
+ Misses 3854 2065 -1789
- Partials 305 622 +317
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
the codecov comment doesn't show the e2e output, saying something about "Flags with carried forward coverage won't be shown. Click here to find out more."? |
@bobcallaway this is happening because the e2e tests take longer to run, codecov updates the comment with e2e coverage once those tests have finished (see the codecov comment now). |
bobcallaway
approved these changes
Sep 23, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 19, 2022
https://build.opensuse.org/request/show/1029934 by user msmeissn + dimstar_suse - updated to rekor 1.0.0 (sc#SLE-23476): - add description on /api/v1/index/retrieve endpoint by @bobcallaway in sigstore/rekor#1073 - Adding e2e test coverage by @cdris in sigstore/rekor#1071 - export rekor build/version information by @cpanato in sigstore/rekor#1074 - Use POST instead of GET for /api/log/entries/retrieve metrics. by @var-sdk in sigstore/rekor#1083 - Search through all shards when searching by hash by @priyawadhwa in sigstore/rekor#1082 - verify: verify checkpoint's STH against the inclusion proof root hash by @asraa in sigstore/rekor#1092 - add ability to enable/disable specific rekor API endpoints by @bobcallaway in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instruments e2e tests for code coverage. Uploads e2e coverage report to codecov as part of github action.
Release Note
NONE
Documentation