Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harness test for getting all entries by UUID and EntryID #957

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Aug 5, 2022

This should be the last PR for harness testing.

Closes https://github.com/sigstore/public-good-instance/issues/417

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa requested a review from a team as a code owner August 5, 2022 21:24
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #957 (1b7a110) into main (45fd37d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   48.35%   48.31%   -0.04%     
==========================================
  Files          61       61              
  Lines        5383     5383              
==========================================
- Hits         2603     2601       -2     
- Misses       2500     2502       +2     
  Partials      280      280              
Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 48.82% <0.00%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dlorenc
dlorenc previously approved these changes Aug 7, 2022
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question otherwise LGTM

tests/harness_test.go Outdated Show resolved Hide resolved
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa merged commit b7e88e3 into sigstore:main Aug 9, 2022
@priyawadhwa priyawadhwa deleted the harness-uuid branch August 9, 2022 01:58
@github-actions github-actions bot added this to the v1.0.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants