Add failure cases for checkpoints #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a.txt.checkpoint_bad_keyhint.sigstore modify the first base64 character of the signature, to affect the keyhint for that signature line a.txt.checkpoint_invalid_signature.sigstore modify the signature so it no longer validates a.txt.checkpoint_wrong_roothash.txt replace the checkpoint with an otherwise valid checkpoint from another bundle (from the same log instance) Signed-off-by: Appu Goundan <appu@google.com>
Member
Author
|
@william since we were talking about this on slack. |
Member
|
Thanks @loosebazooka! Looking today. FYI @william is not me 😉 |
Member
Author
|
loool, poor @william I'm sorry. I don't why auto-fill did this to them. |
woodruffw
approved these changes
Mar 20, 2024
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Thanks @loosebazooka, looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.txt.checkpoint_bad_keyhint.sigstore
modify the first base64 character of the signature, to affect the keyhint for that signature line
a.txt.checkpoint_invalid_signature.sigstore
modify the signature so it no longer validates
a.txt.checkpoint_wrong_roothash.txt
replace the checkpoint with an otherwise valid checkpoint from another bundle (from the same log instance)
This should catch any client not verifying a checkpoint from a bundle. (like sigstore-java was)