Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change registry type to OpenMetrics? #614

Closed
zigazajc007 opened this issue Feb 16, 2024 · 6 comments · Fixed by #626
Closed

How to change registry type to OpenMetrics? #614

zigazajc007 opened this issue Feb 16, 2024 · 6 comments · Fixed by #626

Comments

@zigazajc007
Copy link

image image image
@jamesla
Copy link

jamesla commented Apr 16, 2024

@zigazajc007 Did you solve this?

@zigazajc007
Copy link
Author

@zigazajc007 Did you solve this?

I didn't.

@SimenB
Copy link
Collaborator

SimenB commented Apr 16, 2024

The static prop is just missing from the types, it works at runtime. You can also do Prometheus.openMetricsContentType which is present in types

@SimenB
Copy link
Collaborator

SimenB commented Apr 16, 2024

@jamesla
Copy link

jamesla commented Apr 16, 2024

Thanks @SimenB but this is actualy still not working with the latest version

error TS2345: Argument of type '"application/openmetrics-text; version=1.0.0; charset=utf-8"' is not assignable to parameter of type '"text/plain; version=0.0.4; charset=utf-8"'.

@SimenB
Copy link
Collaborator

SimenB commented Apr 17, 2024

Hah. Still only a type error, so a @ts-ignore should do it.

Happy to take a PR fixing it properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants