Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated .extend method #152

Closed
ericfortmeyer opened this issue Feb 16, 2023 · 1 comment
Closed

Remove deprecated .extend method #152

ericfortmeyer opened this issue Feb 16, 2023 · 1 comment

Comments

@ericfortmeyer
Copy link

Users of the library are seeing this warning in the browser console.

VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
ericfortmeyer pushed a commit to ericfortmeyer/videojs-chromecast that referenced this issue Feb 16, 2023
The warning below is appearing in the browser console:

```
VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
```

Issue silvermine#152
ericfortmeyer pushed a commit to ericfortmeyer/videojs-chromecast that referenced this issue Feb 17, 2023
The warning below is appearing in the browser console:

```
VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
```

Users of this library cannot upgrade Video.js because
the extend method has been removed in version 8.

Closes silvermine#152, Related to silvermine#147
@ericfortmeyer ericfortmeyer changed the title Remove deprecated .extends method Remove deprecated .extend method Feb 20, 2023
ericfortmeyer pushed a commit to ericfortmeyer/videojs-chromecast that referenced this issue Feb 20, 2023
The deprecated `.extend` method should not be called when the modules are imported.  The change in the next commit will allow users of the library to upgrade to video.js version 8 where the `.extend` method has been removed.

Issue silvermine#152
ericfortmeyer pushed a commit to ericfortmeyer/videojs-chromecast that referenced this issue Feb 20, 2023
Users of the library are seeing this warning in the browser console.
```
VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
```
Users will now be able to upgrade to Video.js >= 8 where the `.extend` method has been removed.

Issue silvermine#152, Related to silvermine#147
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Feb 22, 2023
Using classes inheritance instead of the deprecated `.extends` method
will allow users of this library to upgrade VideoJS to version 8.

See silvermine/videojs-chromecast#152
and silvermine/videojs-chromecast#147.

Related to silvermine/videojs-chromecast#152
Related to silvermine/videojs-chromecast#147.
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Feb 22, 2023
Using classes inheritance instead of the deprecated `.extends` method
will allow users of this library to upgrade VideoJS to version 8.

See silvermine/videojs-chromecast#152
and silvermine/videojs-chromecast#147.

Related to silvermine/videojs-chromecast#152
Related to  silvermine/videojs-chromecast#147
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Feb 22, 2023
Using classes inheritance instead of the deprecated `.extends` method
will allow users of this library to upgrade VideoJS to version 8.

See silvermine/videojs-chromecast#152
and silvermine/videojs-chromecast#147.

Related to silvermine/videojs-chromecast#152, Related to silvermine/videojs-chromecast#147.
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Feb 22, 2023
Using classes inheritance instead of the deprecated `.extends` method
will allow users of this library to upgrade VideoJS to version 8.

See silvermine/videojs-chromecast#152
and silvermine/videojs-chromecast#147.

Related to silvermine/videojs-chromecast#152, Related to silvermine/videojs-chromecast#147.
ericfortmeyer pushed a commit to ericfortmeyer/videojs-chromecast that referenced this issue Feb 23, 2023
Users of the library are seeing this warning in the browser console.
```
VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
```
Users will now be able to upgrade to Video.js >= 8 where the `.extend` method has been removed.

Issue silvermine#152, Related to silvermine#147
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Feb 23, 2023
Using classes inheritance instead of the deprecated `.extend` method
will allow users of this library to upgrade VideoJS to version 8.

See silvermine/videojs-chromecast#152
and silvermine/videojs-chromecast#147.

Related to silvermine/videojs-chromecast#152, Related to silvermine/videojs-chromecast#147.
@yokuze
Copy link
Contributor

yokuze commented Feb 24, 2023

This was addressed in #153

@yokuze yokuze closed this as completed Feb 24, 2023
datagutt pushed a commit to GuacLive/videojs-chromecast that referenced this issue Feb 25, 2023
The deprecated `.extend` method should not be called when the modules are imported.  The change in the next commit will allow users of the library to upgrade to video.js version 8 where the `.extend` method has been removed.

Issue silvermine#152
datagutt pushed a commit to GuacLive/videojs-chromecast that referenced this issue Feb 25, 2023
Users of the library are seeing this warning in the browser console.
```
VIDEOJS: WARN: videojs.extend is deprecated as of Video.js 7.22.0 and will be removed in Video.js 8.0.0
```
Users will now be able to upgrade to Video.js >= 8 where the `.extend` method has been removed.

Issue silvermine#152, Related to silvermine#147
ericfortmeyer pushed a commit to ericfortmeyer/videojs-airplay that referenced this issue Mar 13, 2023
The new dependencies are using exact versions.

Related to silvermine/videojs-chromecast#152, Related to silvermine/videojs-chromecast#147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants