PHP 8.4 support

[GuySartorelli]

PHP 8.4 releases on 21 November.

The major release policy states

At launch, a Silverstripe CMS major release supports all PHP versions in full support.

And
> Following the initial launch of a Silverstripe CMS major release, the development team aims to add forward compatibility for the next PHP release. e.g: Silverstripe CMS 5 at launch will support PHP 8.1 and PHP 8.2. CMS 5 should receive official support for an eventual PHP 8.3 in early 2024.

Acceptance criteria

• All CMS 6 supported modules are compatible with PHP 8.4 with no deprecation warnings
• All CMS 5.4 supported modules are compatible with PHP 8.4 with no deprecation warnings

New issues created

• Review third-party PHP 8.4 deprecations before 6.0.0-rc1 #351

CI PRs

• ENH PHP 8.4 for CMS 6 supported-modules#47
• MNT Update unit tests for PHP 8.4 gha-generate-matrix#113
• ENH Use MySQL 8.4 for the PHP 8.4 endtoend job in CMS 6 gha-generate-matrix#114

After merging CI PRs, re-trigger with force push PRs below to get PHP 8.4 jobs in matrix

Kitchen sink CI

• https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12115320472

PRs

• ENH PHP 8.4 support silverstripe-framework#11480
• API PHP 8.4 compatibility changes silverstripe-elemental#1285
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-admin#1863
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-asset-admin#1518
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-assets#662
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-blog#797
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-cms#3032
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-graphql#614
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-hybridsessions#115
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-linkfield#353
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-lumberjack#178
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-realme#171
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-session-manager#227
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-siteconfig#182
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-subsites#617
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-userforms#1352
• API Explicity mark nullable parameters for PHP 8.4 vendor-plugin#87
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-versioned#483
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-versioned-admin#374
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-advancedworkflow#563
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-gridfieldextensions#423
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-queuedjobs#453
• API Explicity mark nullable parameters for PHP 8.4 tractorcow-farm/silverstripe-fluent#911
• API Explicity mark nullable parameters for PHP 8.4 closure#4
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-webauthn-authenticator#202
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-behat-extension#291
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-event-dispatcher#30
• API Explicity mark nullable parameters for PHP 8.4 MinkFacebookWebDriver#29
• MNT Remove unit test metadata silverstripe-textextraction#103
• DOC Add PHP 8.4 support developer-docs#643

[GuySartorelli]

@emteknetnz We don't add PHP 8.4 support to CMS 5. The quote you added is about adding PHP 8.3 support to CMS 5.
Specifically:

the development team aims to add forward compatibility for the next PHP release

Similarly we'll add 8.5 to CMS 6 when it releases, and not 8.6 to CMS 6.

Similarly for CMS 4 we added PHP 8.1 support but not 8.2 or 8.3

[emteknetnz]

Have updated description to remove from CMS 5

[GuySartorelli]

Note that docs also need to be updated - both with a changelog entry and make sure any references to supported PHP versions includes PHP 8.4

[GuySartorelli]

Code changes merged.
Still need docs PR
Please remember to reassign to me when you unassign yourself

[emteknetnz]

Done

[GuySartorelli]

Looking at the framework CI runs, there's still some PHP 8.4 deprecations warnings from our dependencies. Previously we've considered these to be part of PHP compatibility IIRC.

There's likely other deps with similar problems, these were just what I spied from looking at the below CI runs:

https://github.com/silverstripe/silverstripe-framework/actions/runs/12131524771/job/33823951169

PHP Deprecated: SensioLabs\AnsiConverter\AnsiToHtmlConverter::__construct(): Implicitly marking parameter $theme as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/silverstripe-framework/silverstripe-framework/vendor/sensiolabs/ansi-to-html/SensioLabs/AnsiConverter/AnsiToHtmlConverter.php on line 27

https://github.com/silverstripe/silverstripe-framework/actions/runs/12131524771/job/33823950784

Deprecated: Embed\QueryResult::url(): Implicitly marking parameter $attribute as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/silverstripe-framework/silverstripe-framework/vendor/embed/embed/src/QueryResult.php on line 82

and various others from the Embed\ namespace

PHP Deprecated: ML\JsonLD\Processor::listToRdf(): Implicitly marking parameter $graph as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/silverstripe-framework/silverstripe-framework/vendor/ml/json-ld/Processor.php on line 2235

and various others from the ML\JsonLD\ namespace

[emteknetnz]

They're third party deprecation notices for new deprecation notices as of PHP 8.4. There's not a whole lot we can do about those and it's not really our responsibility to fix them. They'll only show if developers turns on deprecation logging with PHP config and they will not affect a production site. They should get fixed over time as people release PHP 8.4 support for those depedencies.

The sensio labs one does have a fix committed, just not tagged

Seems like this issue can now be closed.

[GuySartorelli]

We can't say Silverstripe CMS 6 is PHP 8.4 compatible while there are lots of PHP deprecation warnings being thrown from our dependencies that projects can't opt out of.

In the past we have submitting pull requests providing PHP compatibility where it's missing in our dependencies. We have also previously forked dependencies that refused to update (see https://github.com/silverstripe/closure/ as an example).

Based on what we've done in the past, and in order to be able to say it's PHP 8.4 compatible, I think we should do the following:

• Submit PRs to repos to provide PHP 8.4 support where no PR has yet been submitted
• Open a new card to review the deprecation warnings before we release 6.0.0-rc1 in case we need to do some forking or replace a dependency, or at the very least so that we can provide appropriate comms to indicate that while our codebase has been updated, some upstream dependencies are known to not have done so yet.

[emteknetnz]

Done #351

I think we can now close this issue