Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session storage is not binary safe #32

Closed
dnsl48 opened this issue Jun 26, 2019 · 0 comments · Fixed by #33
Closed

Session storage is not binary safe #32

dnsl48 opened this issue Jun 26, 2019 · 0 comments · Fixed by #33

Comments

@dnsl48
Copy link
Contributor

dnsl48 commented Jun 26, 2019

aws-sdk-php implementation of StandardSessionConnection is not binary safe. The issue reported here: aws/aws-sdk-php#1831

SilverStripe 4.4 core functionality persists some binary data within sessions (ConfirmationMiddleware CSRF), which makes this critical for SilverStripe Platform Multi-AZ, which utilizes DynamoDB as the session storage.
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jun 27, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection handles serialized…
38b706f 
… sessions as strings, which is not binary safe

fixes silverstripe#32
@dnsl48 dnsl48 mentioned this issue Jun 27, 2019
Merged
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jun 27, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection handles serialized…
e304c55 
… sessions as strings, which is not binary safe

fixes silverstripe#32
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jul 1, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection binary safety
a1a0eac 
fixes silverstripe#32
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jul 1, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection binary safety
59b958f 
fixes silverstripe#32
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jul 1, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection binary safety
4031818 
fixes silverstripe#32
dnsl48 added a commit to open-sausages/silverstripe-dynamodb that referenced this issue Jul 1, 2019
@dnsl48
FIX AWS SDK PHP DynamoDb StandardSessionConnection binary safety
fc97543 
fixes silverstripe#32
@chillu chillu closed this as completed in #33 Jul 1, 2019
@dnsl48 dnsl48 mentioned this issue Jul 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

binary safe session persistence open-sausages/silverstripe-dynamodb
1 participant
@dnsl48