VectorIterator has broken assignment operator

[sherm1]

The VectorIterator class keeps a reference to the Vector which prevents copy assignment from working. Nevertheless it contains a copy assignment operator which ends up making a deep copy of the Vector, rather then setting the new reference to be the same as the old one.

This is often a self-copy which is weird and may be slow but possibly harmless which is probably why this wasn't noticed. Valgrind caught it. I'm not sure if this causes any noticeable bugs.

[sherm1]

Fixed in this commit.

[chrisdembia]

FYI IIRC github will close this issue even if you have Fixes #issue in your commit message.

[sherm1]

Thanks -- actually I meant to push this to a separate branch and make a PR but my click finger got away from me and I ended up pushing it right into the master branch by accident. Didn't seem worth undoing it at that point.