Change secure_image_url default from false to true #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@simi any decisions on the merge? With the current default, the gem doesn't work out of the box for new installs :s |
Closed
simi
approved these changes
Feb 9, 2021
|
@swiknaba thanks for this one, it failed out of my radar. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default
secure_image_urltotrue, see #345 for details.closes #345
Notes
As mentioned here #343 (comment) you can just turn on the
secure_image_urlin your settings for now. This PR just aims to change the default value, since it is mandatory. Eventually, in the next major version release, we can drop this option entirely, since there is no point in turning SSL off, if the Facebook API does not support it anymore anyway.