Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: provide functions for split JWT token headers #28

Open
kutyel opened this issue Apr 28, 2024 · 1 comment
Open

Discussion: provide functions for split JWT token headers #28

kutyel opened this issue Apr 28, 2024 · 1 comment

Comments

@kutyel
Copy link

kutyel commented Apr 28, 2024

Hi! Recently a colleague split the bearer token because of some security reasons, thus I ended up having to do this in all my HTTP calls:

                , headers =
                    [ Http.header "x-signature-token" tokens.signatureToken
                    , Http.header "x-header-payload-token" tokens.headerPayloadToken
                    ]

Does it make sense to add Http.{get|delete|put|post} function libs to support that use case to this library? 🤔

@simonh1000
Copy link
Owner

simonh1000 commented Apr 29, 2024

To be honest if I changed anything it would probably be the remove the http stuff all together - chances are there are other headers you want to add anyway - e.g. Content-Type - so I suspect these functions are essentially unused, and rather break the notion of 'do just 1 thing well'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants