Copy derivative of Planck formula from python pixell #53
Conversation
src/utils.jl
Outdated
| const h = 6.62606957e-34 | ||
| const k = 1.3806488e-23 | ||
| const T_cmb = 2.72548 # +/- 0.00057 | ||
| const c = 299792458.0 |
There was a problem hiding this comment.
I'm leary of global constants which are single-letter lowercase. It's really easy to write a for loop with k as the iteration variable, for example. Can you make these local to your function for now?
There was a problem hiding this comment.
it might be nice to use a dependency to the PhysicalConstants package but that doesn't need to happen in this PR.
There was a problem hiding this comment.
@xzackli Thank you for the review and sorry for the delay. I have included the PhysicalConstants dependency.
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 89.23% 89.32% +0.09%
==========================================
Files 7 8 +1
Lines 808 815 +7
==========================================
+ Hits 721 728 +7
Misses 87 87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looks good to me, I'm happy to merge this. Thanks for this nice addition! |
I am working on a project with ACTpol data in Julia, supervised by @guanyilun, that requires the derivative of Planck spectrum. I copied the function and the relevant constants from the https://github.com/simonsobs/pixell
Please let me know if there are contribution guidelines I should be following.