Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vantage windchill #550

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Vantage windchill #550

merged 5 commits into from
Feb 29, 2024

Conversation

RemingtonGerras
Copy link
Contributor

Added wind chill function and report the wind chill temperature during acq process.

Description

Above :)

Motivation and Context

531 (continued)

How Has This Been Tested?

Put functions into a python terminal, checked results with various online calculators.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman self-requested a review November 1, 2023 15:12
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RemingtonGerras! Just one suggestion about the 50F cutoff.

socs/agents/vantagepro2/drivers.py Show resolved Hide resolved
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that temperature limit. Will merge when checks complete.

@BrianJKoopman BrianJKoopman merged commit 6e673e4 into main Feb 29, 2024
6 checks passed
@BrianJKoopman BrianJKoopman deleted the vantage-windchill branch February 29, 2024 16:59
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* Added wind chill temperature to acquisition data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Limit wind chill calc upper range

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Brian Koopman <brian.koopman@yale.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants