Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prints errors caught in the pysmurf-controller subprocesses #674

Merged
merged 2 commits into from
May 21, 2024

Conversation

jlashner
Copy link
Collaborator

Logs errors in pysmurf-controller subprocess.

Description

We are seeing that since the subprocessing change, failures in pysmurf-controller operations are not logging exceptions that are thrown (though the tracebacks are being stored in session.data). This PR adds a log of the traceback when an exception is caught in the subprocess.

Motivation and Context

See here for an example: https://github.com/simonsobs/daq-discussions/discussions/95

How Has This Been Tested?

Not tested yet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit 1760a7a into main May 21, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the controller-error-logging branch May 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants