Add try/except to np.polyfit #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
np.polyfit can fail for some complicated reasons, and it's better to skip a problematic channel than to fail the whole algorithm. I think a try/except here is the easiest solution. I also don't know all the failure modes (TypeError, SystemError, etc.), so I left it as a generic except.
jlashner
approved these changes
Aug 14, 2023
|
Should we leave this except in here even after Jack tracked down the cause and merged the fix? |
|
I think it's good to keep this, we really don't want the analysis function to fail out if we can avoid it, since then you lose the iva object. Its much easier to inspect bad channels and failures if the function finishes and returns the iva object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.polyfit can fail for some complicated reasons, and it's better to skip a problematic channel than to fail the whole algorithm. I think a try/except here is the easiest solution.
I also don't know all the failure modes (TypeError, SystemError, etc.), so I left it as a generic except.