(SIMP-8075) Update Dependencies #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch corrects the regex operator in the `.gitlab-ci.yml` YAML anchor `&skip_job_when_commit_message_says_to`. The previous pipeline had a bug which _always_ skipped spec and acceptance tests (added at the last minute when it was rearranged into semantic anchors, ironically to support `when: never`) CI: SKIP MATRIX SIMP-8038 #close SIMP-7974 #comment Fix when: never regex in .gitlab-ci.yml SIMP-7975 #comment Fix when: never regex in .gitlab-ci.yml [SIMP-7974]: https://simp-project.atlassian.net/browse/SIMP-7974 [SIMP-7975]: https://simp-project.atlassian.net/browse/SIMP-7975
- updated the upperbound of vox_selinux to < 4.0.0 - review showed no need for code changes - update fixtures for iptables changes SIMP-8075 #comment update rsync
jeannegreulich
changed the title
|
I think I have fixed all the rsync problems with PR but there is still and iptables problem causing the tests to fail that is being looked at under SIMP-8238. I just marked this WIP because I can't be absolutely certain the acceptance will run once the iptable is updated. (Although I am pretty sure.) |
Once we added a third host, we ran into the iptables bug that resulted in the creation of the `iptables::precise_match` option (off by default). Adding that to these tests, uncovered another bug so this will need simp/pupmod-simp-iptables#84 to go through prior to the tests working properly.
jeannegreulich
changed the title
trevor-vaughan
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a loop to create the trusted_net list in the tests.
only port is changed. Error does notoccur when firewalld is used.
SIMP-8075 #comment
SIMP-8320 #close