From f0c141ae858daf6332c25563422fb378bb6b932f Mon Sep 17 00:00:00 2001 From: Jeremy Scheff Date: Fri, 8 Jun 2018 15:15:48 -0400 Subject: [PATCH] In ix bid adapter, default to assuming media type is banner (#2632) --- modules/ixBidAdapter.js | 3 ++- test/spec/modules/ixBidAdapter_spec.js | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/modules/ixBidAdapter.js b/modules/ixBidAdapter.js index 3384bb8f41bf..f3ac8185f17e 100644 --- a/modules/ixBidAdapter.js +++ b/modules/ixBidAdapter.js @@ -185,7 +185,8 @@ export const spec = { // If the bid request is for banner, then transform the bid request based on banner format. if (utils.deepAccess(validBidRequest, 'mediaTypes.banner') || - validBidRequest.mediaType === 'banner') { + validBidRequest.mediaType === 'banner' || + (validBidRequest.mediaType === undefined && utils.deepAccess(validBidRequest, 'mediaTypes.banner') === undefined)) { bannerImp = bidToBannerImp(validBidRequest); bannerImps.push(bannerImp); } diff --git a/test/spec/modules/ixBidAdapter_spec.js b/test/spec/modules/ixBidAdapter_spec.js index 0e00a64aab4c..92a7190bcb69 100644 --- a/test/spec/modules/ixBidAdapter_spec.js +++ b/test/spec/modules/ixBidAdapter_spec.js @@ -272,6 +272,21 @@ describe('IndexexchangeAdapter', () => { expect(requestStringTimeout.data.t).to.be.undefined; }); + + it('should default to assuming media type is banner', () => { + const bidsWithoutMediaType = [ + Object.assign({}, DEFAULT_BANNER_VALID_BID[0]) + ]; + delete bidsWithoutMediaType[0].mediaTypes; + + const request = spec.buildRequests(bidsWithoutMediaType); + const payload = JSON.parse(request.data.r); + + expect(payload.id).to.equal(bidsWithoutMediaType[0].bidderRequestId); + expect(payload.imp).to.exist; + expect(payload.imp).to.be.an('array'); + expect(payload.imp).to.have.lengthOf(1); + }); }); describe('interpretResponseBanner', () => {