From b34a1641bcf2ba91fad3006adb564fc3ee0fe947 Mon Sep 17 00:00:00 2001 From: dovchik Date: Mon, 14 Oct 2024 13:52:23 +0200 Subject: [PATCH 1/3] fix: build of restore with correct framework --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 026fff5e..5ece24cb 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -71,7 +71,7 @@ jobs: cd sinch-sdk-internal-specs/fixtures/python/ && java -jar wiremock-studio-2.32.0-17.jar & - name: Install dependencies - run: dotnet restore + run: dotnet restore -p:TargetFrameworks=${{ matrix.dotnet-version.tfm }} - name: Check Formatting run: dotnet format --verify-no-changes --verbosity diagnostic From c3175d938b8da3b5debb5c9d81179aff36ad9080 Mon Sep 17 00:00:00 2001 From: dovchik Date: Mon, 14 Oct 2024 13:59:07 +0200 Subject: [PATCH 2/3] wip: use single most higher framework --- .github/workflows/build.yaml | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5ece24cb..cb837342 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -12,13 +12,6 @@ env: jobs: build: runs-on: ubuntu-latest - strategy: - matrix: - dotnet-version: [ - { version: '6.0.x', tfm: 'net6.0' }, - { version: '7.0.x', tfm: 'net7.0' }, - { version: '8.0.x', tfm: 'net8.0' }, - ] services: doppleganger: @@ -52,11 +45,11 @@ jobs: with: useConfigFile: true - - name: Setup .NET SDK ${{ matrix.dotnet-version.version }} + - name: Setup .NET SDK id: dotnet uses: actions/setup-dotnet@v4 with: - dotnet-version: ${{ matrix.dotnet-version.version }} + dotnet-version: '8.0.x' - name: Checkout Wiremock fixtures repo uses: actions/checkout@v3 @@ -71,7 +64,7 @@ jobs: cd sinch-sdk-internal-specs/fixtures/python/ && java -jar wiremock-studio-2.32.0-17.jar & - name: Install dependencies - run: dotnet restore -p:TargetFrameworks=${{ matrix.dotnet-version.tfm }} + run: dotnet restore - name: Check Formatting run: dotnet format --verify-no-changes --verbosity diagnostic @@ -80,7 +73,7 @@ jobs: run: dotnet build -p:Version=${{ steps.gitversion.outputs.semVer }} --configuration Release --no-restore - name: Test - run: dotnet test --no-restore --verbosity normal --framework ${{ matrix.dotnet-version.tfm }} + run: dotnet test --no-restore --verbosity normal # --include-symbols? - name: Pack From 98a42c89fca1b6ffab4901dd4a78dcb9c6c9d8e1 Mon Sep 17 00:00:00 2001 From: dovchik Date: Mon, 14 Oct 2024 14:10:21 +0200 Subject: [PATCH 3/3] install 3 versions of dotnet --- .github/workflows/build.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index cb837342..7f512481 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -49,7 +49,10 @@ jobs: id: dotnet uses: actions/setup-dotnet@v4 with: - dotnet-version: '8.0.x' + dotnet-version: | + 6.0.x + 7.0.x + 8.0.x - name: Checkout Wiremock fixtures repo uses: actions/checkout@v3