Avoid including node binary path if it already presented #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To preventing override user order in PATH(which used in version managers, example, rvm(ruby version manager))
stiig
changed the title
evocateur
suggested changes
Dec 31, 2018
| @@ -19,7 +19,11 @@ module.exports = opts => { | |||
| } | |||
|
|
|||
| // ensure the running `node` binary is used | |||
| ret.push(path.dirname(process.execPath)); | |||
| const binNodePth = path.dirname(process.execPath); | |||
| const testExisting = new RegExp(`:${binNodePth}:`); | |||
There was a problem hiding this comment.
This won't work on windows, you need to use ${path.delimiter} instead of :
This was referenced Mar 13, 2019
|
I opened PR #4 to make this PR move forward. |
|
Closing this in favor of #5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preventing override user order in PATH(which used in version managers, example, rvm(ruby version manager))