Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hideCursor readme to include SIGINT info #80

Closed
wants to merge 1 commit into from

Conversation

tcodes0
Copy link

@tcodes0 tcodes0 commented Jul 2, 2018

Please let me know if you have any feedback.

@sindresorhus
Copy link
Owner

What's the context?

@diegohaz
Copy link

@sindresorhus We were using meow and ora on https://github.com/diegohaz/singel and having problems to stop logging stuff on SIGINT.

It took us a long time to figure out what was blocking the process, and turned out that both ora and meow were responsible for that. We replaced meow by commander and added the hideCursor option to ora and everything was fixed. (here: diegohaz/singel#17)

That would be easier if the readme said something about that.

@sindresorhus
Copy link
Owner

sindresorhus commented Jul 17, 2018

Sounds like tapjs/signal-exit#49 You should comment there with some more info or open a new issue there.

@diegohaz
Copy link

Didn't get it. What does that package have to do with ora or hideCursor?

@tcodes0
Copy link
Author

tcodes0 commented Jul 21, 2018

Sorry @sindresorhus I posted the context here: #27 (comment). It's related to that. It's as @diegohaz said, we were making a cli that wasn't dying on SIGINT, and it turned out to be related to the hideCursor option.

Then you're basically saying the problem lies in tapjs/signal-exit, could you please elaborate why? Is it a dependency to ora? I posted there.

@sindresorhus
Copy link
Owner

Closing in favor of tapjs/signal-exit#49.

Copy link

@ubsasi ubsasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants