Remove Opaque/UnwrapOpaque #823
Open
+48
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanresnick
force-pushed
the
remove-opaque
branch
18 times, most recently
from
dbbf3f9
to
570a494
Compare
nplusp
reviewed
Apr 3, 2024
|
We can do a |
ethanresnick
force-pushed
the
remove-opaque
branch
2 times, most recently
from
c795028
to
f575854
Compare
ethanresnick
force-pushed
the
remove-opaque
branch
3 times, most recently
from
6741610
to
9ba360b
Compare
|
Can you also update the README section "Alternative type names" where Branded redirects to Opaque instead of Tagged? |
ethanresnick
force-pushed
the
remove-opaque
branch
from
9ba360b
to
6f8998c
Compare
|
@KinderGouello Done, here and in #867. |
ethanresnick
force-pushed
the
remove-opaque
branch
2 times, most recently
from
f871c1c
to
07fbd83
Compare
ethanresnick
force-pushed
the
remove-opaque
branch
from
07fbd83
to
531414d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may be premature, so I'm happy to let it sit for a bit. But, the basic idea is that:
Taggedtypes are strictly more powerful thanOpaqueones, thanks to their ability to more naturally support multiple tags.Opaquehas always been misnamed (since the underlying, untagged type isn't hidden at all, which is a critical property of opaque types in other languages).OpaqueandUnwrapOpaqueshould be removed.