Make ensure_ascii Dynamic with Default Set to True in JSON Serialization
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
changed the title
ensure_ascii=False
sgandhi1311
changed the title
ensure_ascii=Falseensure_ascii Dynamic with Default Set to True in JSON Serialization
cosimon
approved these changes
Aug 9, 2024
jesuejunior
added a commit
to sixcodes/singer-python
that referenced
this pull request
Oct 5, 2024
* parse dev mode argument (singer-io#158) * parse dev mode argument * update the short flag for dev mode Replace `-dev` to `-D` * Updated the short flag for dev mode * - remove dev mode short flag Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com> * Bump version 5.13.0 (singer-io#160) * Bump version 5.13.0 * update changelog for dev mode argument parsing * change versioning to minor version bump Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com> * Bump backoff to be compatible with newer python versions (singer-io#165) * bump backoff for pyton 3.11 compatibility * update pip version * try new circleci yml * remove 'make' * make pylint happy * make pylint happy * make pylint happy again * backoff version is a breaking change for old python versions * Changelog update * Relax dependency version requirements (singer-io#167) * Relax dependency constraints * Bump version to `6.0.1` * pin backoff and simplejson to major version * Don't allow older versions * Update changelog * Pin minumum and major versions * Make `ensure_ascii` Dynamic with Default Set to `True` in JSON Serialization (singer-io#168) * add parameter - ensure_ascii to load non ascii characters when set to false * add unit test for ensuring ascii characters while loading * update setup and changelog * Enable copilot usage in PR template according to Qlik policy * removing simplejson dep and improve dep version * Adding * bumping version * Removing use_decimal param for json.dumps * Adding a consig to be able to send message to pubsub * Extracting to a F * pubsub doesnt expect None as attr * Parsing state to be used as attr in pubsub * Set state as stream name when type is state * feat: supporting a simple entry from lakehouse lib to send messages to a queue * chore(deps) make jsonschema version flexible --------- Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com> Co-authored-by: RushiT0122 <rtodkar@stitchdata-talend.com> Co-authored-by: Leslie VanDeMark <38043390+leslievandemark@users.noreply.github.com> Co-authored-by: Bryant Gray <bryant.gray@qlik.com> Co-authored-by: Sourabh Gandhi <105213416+sgandhi1311@users.noreply.github.com> Co-authored-by: Eivin Giske Skaaren <eivin.skaaren@qlik.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces a dynamic setting for the ensure_ascii parameter in the
json.dumpsfunction, with its default value set toTrue. This change allows for greater flexibility in JSON serialization, enabling non-ASCII characters to be preserved when needed by explicitly passingensure_ascii=False.Manual QA steps
Risks
Rollback steps