Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for inconsistent c strftime implementations #3

Merged
merged 2 commits into from
Feb 28, 2018
Merged

fix for inconsistent c strftime implementations #3

merged 2 commits into from
Feb 28, 2018

Conversation

drewbanin
Copy link
Contributor

This PR tweaks the implementation of strftime to:

  • try using the Singer strftime implementation
  • fall back to an alternative date fmt string: %Y-%m-%dT%H:%M:%S.%fZ

As a result, tap-codat should now work on any system regardless of the underlying C strftime implementation

@KAllan357
Copy link
Contributor

👍

@KAllan357 KAllan357 merged commit 4c3a143 into singer-io:master Feb 28, 2018
@drewbanin drewbanin deleted the fix/strftime-clib branch February 28, 2018 16:42
@nick-mccoy nick-mccoy mentioned this pull request Mar 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbanin @KAllan357