.define method

[gukoff]

Purpose (TL;DR) - mandatory

Add the .define(obj, property, value) method to the sandbox to allow temporarily define properties on the objects (i.e. until the sandbox is restored).

Fixes #2195

How to verify - mandatory

Run the tests

Checklist for author

• npm run lint passes
• References to standard library functions are cached.

[fatso83]

This looks like a great start! I'll leave this for next week, as I am off to a train to the mountains. Thanks!

[fatso83]

Seems pretty ready for inclusion. Just added some comments. You are free to object.

[codecov]

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.21% 🎉

Comparison is base (fe799e7) 95.73% compared to head (ac18f5f) 95.95%.
Report is 2 commits behind head on main.

❗ Current head ac18f5f differs from pull request most recent head d8d7d15. Consider uploading reports for the commit d8d7d15 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
+ Coverage   95.73%   95.95%   +0.21%     
==========================================
  Files          40       40              
  Lines        1901     1904       +3     
==========================================
+ Hits         1820     1827       +7     
+ Misses         81       77       -4     

Flag	Coverage Δ
unit	95.95% <85.71%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
lib/sinon/util/core/default-config.js	100.00% <ø> (ø)
lib/sinon/sandbox.js	97.34% <85.71%> (+1.82%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fatso83]

[warn] Code style issues found in 2 files. Forgot to run Prettier?

Could you just address this and I'll merge 😄