For each 'bit' in the filter we really maintain 2 bits, which store either:
0: not set
1-3: set in generation N

After (nElements / 2) insertions, we switch to a new generation, and wipe
entries which already had the new generation number, effectively switching
from the last 1.5 * nElements set to the last 1.0 * nElements set.

This is 25% more space efficient than the previous implementation, and can
(at peak) store 1.5 times the requested amount of history (though only
1.0 times the requested history is guaranteed).

The existing unit tests should be sufficient.

Mruset setInventoryKnown was reduced to a remarkably small 1000
 entries as a side effect of sendbuffer size reductions in 2012.

This removes setInventoryKnown filtering from merkleBlock responses
 because false positives there are especially unattractive and
 also because I'm not sure if there aren't race conditions around
 the relay pool that would cause some transactions there to
 be suppressed. (Also, ProcessGetData was accessing
 setInventoryKnown without taking the required lock.)

Previously this logic could erroneously filter a MSG_BLOCK inventory message.

Previously this logic could erroneously filter a MSG_BLOCK inventory message.

This is a pure utility function that doesn't use
main's data structures, so it does not require that lock.

Redo the feerate index to be based on mining score, rather than fee.

Update mempool_packages.py to test prioritisetransaction's effect on
package scores.

One test in AcceptToMemoryPool was to compare a transaction's fee
agains the value returned by GetMinRelayFee. This value was zero for
all small transactions.  For larger transactions (between
DEFAULT_BLOCK_PRIORITY_SIZE and MAX_STANDARD_TX_SIZE), this function
was preventing low fee transactions from ever being accepted.

With this function removed, we will now allow transactions in that range
with fees (including modifications via PrioritiseTransaction) below
the minRelayTxFee, provided that they have sufficient priority.

... in preparation for 0.13

aa4b0c2 When not filtering blocks, getdata sends more in one test (Pieter Wuille)
d41e44c Actually only use filterInventoryKnown with MSG_TX inventory messages. (Gregory Maxwell)
b6a0da4 Only use filterInventoryKnown with MSG_TX inventory messages. (Patick Strateman)
6b84935 Rename setInventoryKnown filterInventoryKnown (Patick Strateman)
e206724 Remove mruset as it is no longer used. (Gregory Maxwell)
ec73ef3 Replace setInventoryKnown with a rolling bloom filter. (Gregory Maxwell)

086ee67 Switch to a more efficient rolling Bloom filter (Pieter Wuille)

b440409 Add missing automake package to deb-based UNIX install instructions. (Matt Bogosian)

Mempool requests use a fair amount of bandwidth when the mempool is large,
 disconnecting peers using them follows the same logic as disconnecting
 peers fetching historical blocks.

6aadc75 Disconnect on mempool requests from peers when over the upload limit. (Gregory Maxwell)

Remove necessity to call create_callback_map (as well as the function
itself) from the Python P2P test framework. Invoke the appropriate
methods directly.

- Easy to forget to call it and wonder why it doesn't work
- Simplifies the code
- This makes it easier to handle new messages in subclasses

This is unnecessary during the current tests (any test for Tor
interaction can explicitly enable it) and interferes with the proxy
test.

4c40ec0 tests: Disable Tor interaction (Wladimir J. van der Laan)

96918a2 Don't do mempool lookups for "mempool" command without a filter (Matt Corallo)

A further pass over the available inputs has been added to ApproximateBestSubset after a candidate set has been found. It will prune any extraneous inputs in the selected subset, in order to decrease the number of input and the resulting change.

2f601d2 test: remove necessity to call create_callback_map (Wladimir J. van der Laan)

ca188c6 log bytes recv/sent per command (Jonas Schnelli)

Ever since we bitcoin#5913 have been sending invalid reject messages
for transactions and blocks.

Looks like these were forgotten in bitcoin#6589.

…formance impact

…stSet

e3bc5e0 net: Account for `sendheaders` `verack` messages (Wladimir J. van der Laan)

fc0f52d Added a test for the pruning of extraneous inputs after ApproximateBestSet (Murch)
af9510e Moved set reduction to the end of ApproximateBestSubset to reduce performance impact (Murch)
5c03483 Coinselection prunes extraneous inputs from ApproximateBestSubset (AlSzacrel)

Extend P2P test framework to make it possible to expect reject
codes for transactions and blocks.

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

2041190 test: Add basic test for `reject` code (Wladimir J. van der Laan)
9fc6ed6 net: Fix sent reject messages for blocks and transactions (Wladimir J. van der Laan)

- Avoids string typos (by making the compiler check)
- Makes it easier to grep for handling/generation of a certain message type
- Refer directly to documentation by following the symbol in IDE
- Move list of valid message types to protocol.cpp:
    protocol.cpp is a more appropriate place for this, and having
    the array there makes it easier to keep things consistent.

For opensource.org/licenses/MIT!

…y reviewed.

00423e1 Set link from http:// to https:// (Suriyaa Kudo)

9bbe71b net: Add and document network messages in protocol.h (Wladimir J. van der Laan)

6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)

We used to have a trickle node, a node which was chosen in each iteration of
the send loop that was privileged and allowed to send out queued up non-time
critical messages. Since the removal of the fixed sleeps in the network code,
this resulted in fast and attackable treatment of such broadcasts.

This pull request changes the 3 remaining trickle use cases by random delays:
* Local address broadcast (while also removing the the wiping of the seen filter)
* Address relay
* Inv relay (for transactions; blocks are always relayed immediately)

The code is based on older commits by Patrick Strateman.

CWalletTx::GetAmounts could not find output address for null data transactions, thus issuing an error in debug.log. This change checks to see if the transaction is OP_RETURN before issuing error.

resolves bitcoin#6142

daf6466 Add "NODE_BLOOM" to guiutil so that peers don't get UNKNOWN[4] (Matt Corallo)

e1030dd Note that reviewers should mention the commit hash of the commits they reviewed. (Patrick Strateman)

979698c [RPC-Tests] add option to run rpc test over QT clients (Jonas Schnelli)

d812daf fix logic for error log (accraze)
c611acc wallet: check if tx scriptPubKey is unspendable (accraze)
b6915b8 checks for null data transaction before debug.log (accraze)

5400ef6 Replace trickle nodes with per-node/message Poisson delays (Pieter Wuille)

In rpc-tests.py, don't override BITCOIND and BITCOINCLI if they're
already set. Makes it possible to run the tests with either another tree
or the GUI.

e18378e Removed offline testnet DNSSeed 'alexykot.me'. (Elias Rohrer)

83cdcbd test: don't override BITCOIND and BITCOINCLI if they're set (Wladimir J. van der Laan)

e0769e1 [depends] Latest config.guess & config.sub (fanquake)
23a3c47 [depends] zeromq 4.0.7 (fanquake)
10d3c77 [depends] Fix miniupnpc compilation on osx (fanquake)
26f8ea5 [depends] native ccache 3.2.4 (fanquake)
17ad964 [depends] miniupnpc 1.9.20151026 (fanquake)
9e940fa [depends] Boost 1.59.0 (fanquake)

901b01d Remove GetMinRelayFee (Suhas Daftuar)
27fae34 Use fee deltas for determining mempool acceptance (Suhas Daftuar)
9ef2a25 Update replace-by-fee logic to use fee deltas (Suhas Daftuar)
eb30666 Fix mempool limiting for PrioritiseTransaction (Suhas Daftuar)

9b41a5f Add more tests to p2p-fullblocktest (Suhas Daftuar)

37d271d Rename OP_NOP2 to OP_CHECKLOCKTIMEVERIFY. (mb300sd)

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

7632cf6 [Tests] Refactor some shared functions (Jonas Schnelli)
110ff11 [Tests] Add mempool_limit.py test (Jonas Schnelli)

fa2f4bc qt5: Use the fixed font the system recommends (MarcoFalke)

…ecifier (usually when it only has one possible value)

Strings in a HTML context should be using formatHtmlWithUnit.

The manpages are outdated and are very rarely updated when changes
to the code happen.

Update the description to match that description in
the main bitcoin README.md

7ef8f3c Report non-mandatory script failures correctly (Pieter Wuille)

33877ed Add note to CoinControl Dialog workaround (fanquake)

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

fa09562 [gitian] Set reference date to something more recent (MarcoFalke)