Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better approach for calculation global match #51

Open
siv2r opened this issue Feb 24, 2021 · 0 comments
Open

Find better approach for calculation global match #51

siv2r opened this issue Feb 24, 2021 · 0 comments
Labels
discussion Input from other contributors is required enhancement New feature or request help wanted Extra attention is needed more info needed on hold Some features needs to be merged before implementing this

Comments

@siv2r
Copy link
Owner

siv2r commented Feb 24, 2021

How is the global match calculated? (current scenario)

  • graph.json (using information stored in the database) file is created in the server
  • pipeline.py is called using file
  • The above step stores its output in a result folder in the server
  • Finally, the output.png is displayed from the created result folder

This approach seems good, right? 🤔

Problem
If two people try to find a global match simultaneously, the graph.json and result folders will be overwritten.

Possible solutions

  • allow pipline.py to create multiple result folders instead of one.
    • This will become an issue if many users run this at the same time.
    • Should we delete the result folder after the user sees the info??
    • Can we store the result data in the user session?
  • Instead of creating graph.json, we can pass this info through a variable in PHP and similarly store the pipeline.py output in a variable?
@siv2r siv2r added enhancement New feature or request help wanted Extra attention is needed urgent more info needed discussion Input from other contributors is required on hold Some features needs to be merged before implementing this and removed urgent labels Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Input from other contributors is required enhancement New feature or request help wanted Extra attention is needed more info needed on hold Some features needs to be merged before implementing this
Projects
None yet
Development

No branches or pull requests

1 participant