Issue 2917 #3
Closed
Issue 2917 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `falseIfMissing` to handle errors caused by missing elements in `isEnabled` check. Fixes failing test in angular#3972
…itions Add test cases to reproduce the missing element race conditions possible in expected condition methods `visibilityOf`, `textToBePresentInElement`, `textToBePresentInValue` and `elementToBeClickable`.
Add error handling for missing elements to fix race condition test cases. angular#3972
Add test cases for `isDisplayed`, `isSelected` and `isEnabled`
|
@sjelin Should I open the PR directly to the protractor repo? If you merge my changes to your branch first, the discussion in angular#3972 is not lost. |
|
The changes until e27c035 worked on CircleCI |
|
a7f700f is failing as described |
|
Hey, thanks for the fix + testcases! Probably the best thing to do is for you to submit this as a PR against protractor directly, then I'll clean it up a bit (just to make it more consistant with other protractor changes) and merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix the failing tests in your PR angular#3972
Actually, I'm not sure if my changes to element.ts are correct, because this part of the code is quite complex. Although they prevent exceptions in the expected conditions, they return undefined for all test cases I added.
I also added some test cases to cover the other expected condition methods.