New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar.dateComponents was not zeroing unset components fields #23

Merged

marcprux merged 1 commit into main from calendar-timezone-handling

Oct 4, 2024

Contributor

marcprux commented Oct 4, 2024 •

edited

Loading

This bug could lead to the following code returning inconsistent dates between Foundation and SkipFoundation:

let date = Date(timeIntervalSince1970: 1728038797.580)
let calendar = Calendar.current
calendar.timeZone = TimeZone(identifier: "Europe/Zurich")!

let components = calendar.dateComponents([.year, .month, .day], from: date)
let date2 = calendar.date(from: components)!

The problem is that on Foundation, the DateComponents zeros out all the un-set fields for the Date is that is returned, whereas we were not.


          Calendar.dateComponents was not zeroing unset components fields

62a25a2

cla-bot bot added the cla-signed label

marcprux merged commit 0385dd1 into main

3 checks passed

marcprux mentioned this pull request

Calendar date adding wrappingComponents implementation is incorrect #17

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels