Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS Registry migration #237

Closed
angerborn opened this issue Feb 4, 2020 · 9 comments · Fixed by #243
Closed

ENS Registry migration #237

angerborn opened this issue Feb 4, 2020 · 9 comments · Fixed by #243
Labels
enhancement New feature or request

Comments

@angerborn
Copy link

Due to a bug in the old contract (the ones used by this library at the moment), the ens registries are being migrated.

See:
https://medium.com/the-ethereum-name-service/ens-registry-migration-bug-fix-new-features-64379193a5a
And:
https://docs.ens.domains/ens-migration/guide-for-dapp-developers

Since this was deployed on feb 3rd, any resolved addresses using the old registry may return old data.

@skywinder
Copy link
Collaborator

skywinder commented Feb 16, 2020

thank you for contribution.
I would be happy to give you some bounty for this update as well from gitcoin Grant
@angerborn please, apply for this bounty via Gitcoin 👍

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.045 ETH (11.92 USD @ $264.8/ETH) attached to it.

aranhaagency added a commit to aranhaagency/web3swift that referenced this issue Feb 16, 2020
@aranhaagency
Copy link
Contributor

I made the change but I will wait for the return of @angerborn he has the right to the bounty.

@skywinder
Copy link
Collaborator

skywinder commented Feb 17, 2020

Thanks for the quick response! It mostly have been done by @angerborn , but I will handle this. to make everyone get the reward for open-source coding Thank you all!

@angerborn,'s PR deletes testnetwork addresses.
@aranhaagency you PR looks ready to merge, I left comments to your PR as well.

p.s.
I would be very appreciated if you can check #239 this issue also part of gitcoin bounty program

@aranhaagency
Copy link
Contributor

aranhaagency commented Feb 17, 2020

Thanks @skywinder, about #239 I think is bug in go-ethereum, I wait for update release for better verification.

@gitcoinbot
Copy link

⚡️ A tip worth 0.04000 ETH (10.56 USD @ $264.11/ETH) has been granted to @aranhaagency for this issue from @skywinder. ⚡️

Nice work @aranhaagency! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This Bounty has been completed.

Additional Tips for this Bounty:

  • skywinder tipped 0.0400 ETH worth 10.56 USD to aranhaagency.

@skywinder
Copy link
Collaborator

Oh, mentioned, that the second 10$ tip sent to @aranhaagency too. I supposed to send! @angerborn as the kind of respect his Pr

cc
@aranhaagency

You received double bounty by 0.04 eth. Can you kindly send it to @angerborn ? 😅

@skywinder skywinder added the enhancement New feature or request label Apr 2, 2020
@skywinder
Copy link
Collaborator

Hello, again @angerborn & @aranhaagency! Thanks for the contribution, hope you've like and use our library! :)
In order to make more funds program like this we are participating in the Gitcoin Grant program, so they distribute money to open-source projects.
Every DAI and ETH counts.
If you willing to support us - please send any amount via https://gitcoin.co/grants/358/web3swiftIt it helps us a lot to keep moving!

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants