let some functions public for customization #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamatar
reviewed
Mar 20, 2019
| public var jsonrpc: String = "2.0" | ||
| public var method: JSONRPCmethod? | ||
| public var params: JSONRPCparams? | ||
| public var id: UInt64 = Counter.increment() |
There was a problem hiding this comment.
I understand that public constructor for a “Dispatcher” may be necessary, but request should not be messed up with (or please provide a concrete example for what reason). May be extending a list of JSONRPCmethod is better approach?
There was a problem hiding this comment.
I want to integrate web3 with native wallet app and need to read method/params/id to determine whether to intercept the request. For example, I want to intercept eth.sendTransaction request and handle it by myself, so I need to know method first and then use id / params to process the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.