From 3d692c8b3ff9e32f7a297597c4f4a3e4b0f2ec90 Mon Sep 17 00:00:00 2001 From: "@zimeg" Date: Wed, 19 Jun 2024 10:52:31 -0700 Subject: [PATCH 1/2] style: format the workflow yml file --- .github/workflows/ci-build.yml | 39 +++++++++++++++++----------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 19f53d177..677919351 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -5,12 +5,11 @@ name: Node.js CI on: push: - branches: [ main ] + branches: [main] pull_request: jobs: build: - runs-on: ubuntu-latest timeout-minutes: 10 @@ -20,21 +19,21 @@ jobs: node-version: [12.x, 14.x, 16.x, 18.x, 20.x] steps: - - uses: actions/checkout@v4 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - - run: npm install - - name: Print eslint version - run: ./node_modules/.bin/eslint -v - - run: npm run build - - run: npm test - - name: Upload coverage to Codecov - if: matrix.node-version == '20.x' - uses: codecov/codecov-action@v4 - with: - token: ${{ secrets.CODECOV_TOKEN }} - directory: coverage - fail_ci_if_error: true - verbose: true + - uses: actions/checkout@v4 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + - run: npm install + - name: Print eslint version + run: ./node_modules/.bin/eslint -v + - run: npm run build + - run: npm test + - name: Upload coverage to Codecov + if: matrix.node-version == '20.x' + uses: codecov/codecov-action@v4 + with: + token: ${{ secrets.CODECOV_TOKEN }} + directory: coverage + fail_ci_if_error: true + verbose: true From f98babd8112b36634121cfe0098db62d6f0b5743 Mon Sep 17 00:00:00 2001 From: "@zimeg" Date: Wed, 19 Jun 2024 10:53:00 -0700 Subject: [PATCH 2/2] ci: include node 22 in the testing matrix --- .github/workflows/ci-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 677919351..b10049dc4 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -16,7 +16,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [12.x, 14.x, 16.x, 18.x, 20.x] + node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v4 @@ -30,7 +30,7 @@ jobs: - run: npm run build - run: npm test - name: Upload coverage to Codecov - if: matrix.node-version == '20.x' + if: matrix.node-version == '22.x' uses: codecov/codecov-action@v4 with: token: ${{ secrets.CODECOV_TOKEN }}