FIX: Line edit value setting on Python 3.10+ #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this method, when 'channeltype' is 'int', we correctly set both the value and 'scale' to integers. However, we didn't set the resulting division to an integer as well. Since integer division can result in a non-integer number, the result is sometimes (maybe all the times?) a 'float' type. This didn't cause much trouble before Python 3.10, since Python would automatically convert the floating-point number to an integer. At most you got a Deprecation warning telling you that this isn't the best thing to do. However, starting with 3.10, that conversion no longer works, so the resulting number that gets sent to the communication channel is a mess no longer resembling the original, causing issues. This patch simply wraps the division into an explicit conversion to 'channeltype', avoiding the issue. Signed-off-by: flowln <thiago.ferreira@lnls.br>
Previously this test would succeed with a deprecation warning in Python 3.9 and prior, and fail in 3.10+. After the last commit, this should succeed with no warnings on all Python versions. Signed-off-by: flowln <thiago.ferreira@lnls.br>
jbellister-slac
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably another instance of #951, though it seems like the only one caught in the test coverage, since resolving it also removes the deprecation warning for that issue (or I misunderstood something about those warnings, which is highly possible :P).