Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: Requests #1021

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Remove Unused Dependency: Requests #1021

merged 1 commit into from
Aug 10, 2023

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 9, 2023

Summary

This pull request removes the unused dependency requests from the requirements.txt configuration file as well as from the meta.yaml file, which is used for defining the Conda package attributes, inside the conda_recipe directory. This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The requests package was removed from the source code in this commit, but it still remained as a requirement in the project's dependencies files. Since it is no longer being utilized within the project, removing this unused dependency will reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

  • Removed the requests dependency from the requirements.txt file.
  • Removed the requests dependency from the meta.yaml file in the conda_recipe directory.

Impact

  • Reduced Package Size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified Dependency Tree: Fewer dependencies make the project easier to maintain and can speed up installation.

@gdrosos gdrosos changed the title Remove unused dependency: requests Remove Unused Dependency: Requests Aug 10, 2023
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@YektaY YektaY merged commit fc1830a into slaclab:master Aug 10, 2023
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants